|
@@ -1,168 +0,0 @@
|
1
|
|
-From 6de26b94089929e4cc57c23aa07ae78cfb6ef2a5 Mon Sep 17 00:00:00 2001
|
2
|
|
-From: Nikos Mavrogiannopoulos <nmav@gnutls.org>
|
3
|
|
-Date: Sat, 26 Jul 2014 10:57:26 +0200
|
4
|
|
-Subject: [PATCH 1/2] made macro usage safer
|
5
|
|
-
|
6
|
|
-That solves an issue where the pid_file would be overwritten on
|
7
|
|
-a configuration file reload.
|
8
|
|
----
|
9
|
|
- src/config.c | 24 ++++++++++++------------
|
10
|
|
- src/sup-config/file.c | 20 ++++++++++----------
|
11
|
|
- 2 files changed, 22 insertions(+), 22 deletions(-)
|
12
|
|
-
|
13
|
|
-diff --git a/src/config.c b/src/config.c
|
14
|
|
-index f87fcfc..bc7a0b1 100644
|
15
|
|
---- a/src/config.c
|
16
|
|
-+++ b/src/config.c
|
17
|
|
-@@ -158,7 +158,7 @@ unsigned j;
|
18
|
|
- return NULL;
|
19
|
|
- }
|
20
|
|
-
|
21
|
|
--#define READ_MULTI_LINE(name, s_name, num) \
|
22
|
|
-+#define READ_MULTI_LINE(name, s_name, num) { \
|
23
|
|
- val = get_option(name, &mand); \
|
24
|
|
- if (val != NULL && val->valType == OPARG_TYPE_STRING) { \
|
25
|
|
- if (s_name == NULL) { \
|
26
|
|
-@@ -181,9 +181,9 @@ unsigned j;
|
27
|
|
- } else if (mand != 0) { \
|
28
|
|
- fprintf(stderr, "Configuration option %s is mandatory.\n", name); \
|
29
|
|
- exit(1); \
|
30
|
|
-- }
|
31
|
|
-+ }}
|
32
|
|
-
|
33
|
|
--#define READ_MULTI_BRACKET_LINE(name, s_name, s_name2, num) \
|
34
|
|
-+#define READ_MULTI_BRACKET_LINE(name, s_name, s_name2, num) { \
|
35
|
|
- val = get_option(name, &mand); \
|
36
|
|
- if (val != NULL && val->valType == OPARG_TYPE_STRING) { \
|
37
|
|
- if (s_name == NULL || s_name2 == NULL) { \
|
38
|
|
-@@ -211,25 +211,25 @@ unsigned j;
|
39
|
|
- } else if (mand != 0) { \
|
40
|
|
- fprintf(stderr, "Configuration option %s is mandatory.\n", name); \
|
41
|
|
- exit(1); \
|
42
|
|
-- }
|
43
|
|
-+ }}
|
44
|
|
-
|
45
|
|
--#define READ_STRING(name, s_name) \
|
46
|
|
-+#define READ_STRING(name, s_name) { \
|
47
|
|
- val = get_option(name, &mand); \
|
48
|
|
- if (val != NULL && val->valType == OPARG_TYPE_STRING) \
|
49
|
|
- s_name = talloc_strdup(config, val->v.strVal); \
|
50
|
|
- else if (mand != 0) { \
|
51
|
|
- fprintf(stderr, "Configuration option %s is mandatory.\n", name); \
|
52
|
|
- exit(1); \
|
53
|
|
-- }
|
54
|
|
-+ }}
|
55
|
|
-
|
56
|
|
--#define READ_STATIC_STRING(name, s_name) \
|
57
|
|
-+#define READ_STATIC_STRING(name, s_name) { \
|
58
|
|
- val = get_option(name, &mand); \
|
59
|
|
- if (val != NULL && val->valType == OPARG_TYPE_STRING) \
|
60
|
|
- snprintf(s_name, sizeof(s_name), "%s", val->v.strVal); \
|
61
|
|
- else if (mand != 0) { \
|
62
|
|
- fprintf(stderr, "Configuration option %s is mandatory.\n", name); \
|
63
|
|
- exit(1); \
|
64
|
|
-- }
|
65
|
|
-+ }}
|
66
|
|
-
|
67
|
|
- #define READ_TF(name, s_name, def) \
|
68
|
|
- { char* tmp_tf = NULL; \
|
69
|
|
-@@ -244,7 +244,7 @@ unsigned j;
|
70
|
|
- talloc_free(tmp_tf); \
|
71
|
|
- }
|
72
|
|
-
|
73
|
|
--#define READ_NUMERIC(name, s_name) \
|
74
|
|
-+#define READ_NUMERIC(name, s_name) { \
|
75
|
|
- val = get_option(name, &mand); \
|
76
|
|
- if (val != NULL) { \
|
77
|
|
- if (val->valType == OPARG_TYPE_NUMERIC) \
|
78
|
|
-@@ -254,9 +254,9 @@ unsigned j;
|
79
|
|
- } else if (mand != 0) { \
|
80
|
|
- fprintf(stderr, "Configuration option %s is mandatory.\n", name); \
|
81
|
|
- exit(1); \
|
82
|
|
-- }
|
83
|
|
-+ }}
|
84
|
|
-
|
85
|
|
--#define READ_PRIO_TOS(name, s_name) \
|
86
|
|
-+#define READ_PRIO_TOS(name, s_name) { \
|
87
|
|
- val = get_option(name, &mand); \
|
88
|
|
- if (val != NULL) { \
|
89
|
|
- if (val->valType == OPARG_TYPE_STRING) { \
|
90
|
|
-@@ -271,7 +271,7 @@ unsigned j;
|
91
|
|
- } else if (mand != 0) { \
|
92
|
|
- fprintf(stderr, "Configuration option %s is mandatory.\n", name); \
|
93
|
|
- exit(1); \
|
94
|
|
-- }
|
95
|
|
-+ }}
|
96
|
|
-
|
97
|
|
-
|
98
|
|
- static int handle_option(const tOptionValue* val)
|
99
|
|
-diff --git a/src/sup-config/file.c b/src/sup-config/file.c
|
100
|
|
-index 20a97f2..44c4a9d 100644
|
101
|
|
---- a/src/sup-config/file.c
|
102
|
|
-+++ b/src/sup-config/file.c
|
103
|
|
-@@ -61,7 +61,7 @@ static struct cfg_options available_options[] = {
|
104
|
|
- { .name = "cgroup", .type = OPTION_STRING, },
|
105
|
|
- };
|
106
|
|
-
|
107
|
|
--#define READ_RAW_MULTI_LINE(name, s_name, num) \
|
108
|
|
-+#define READ_RAW_MULTI_LINE(name, s_name, num) { \
|
109
|
|
- val = optionGetValue(pov, name); \
|
110
|
|
- if (val != NULL && val->valType == OPARG_TYPE_STRING) { \
|
111
|
|
- if (s_name == NULL) { \
|
112
|
|
-@@ -77,26 +77,26 @@ static struct cfg_options available_options[] = {
|
113
|
|
- num++; \
|
114
|
|
- } while((val = optionNextValue(pov, val)) != NULL); \
|
115
|
|
- s_name[num] = NULL; \
|
116
|
|
-- }
|
117
|
|
-+ }}
|
118
|
|
-
|
119
|
|
--#define READ_RAW_STRING(name, s_name) \
|
120
|
|
-+#define READ_RAW_STRING(name, s_name) { \
|
121
|
|
- val = optionGetValue(pov, name); \
|
122
|
|
- if (val != NULL && val->valType == OPARG_TYPE_STRING) { \
|
123
|
|
- if (s_name != NULL) \
|
124
|
|
- talloc_free(s_name); \
|
125
|
|
- s_name = talloc_strdup(proc, val->v.strVal); \
|
126
|
|
-- }
|
127
|
|
-+ }}
|
128
|
|
-
|
129
|
|
--#define READ_RAW_NUMERIC(name, s_name) \
|
130
|
|
-+#define READ_RAW_NUMERIC(name, s_name) { \
|
131
|
|
- val = optionGetValue(pov, name); \
|
132
|
|
- if (val != NULL) { \
|
133
|
|
- if (val->valType == OPARG_TYPE_NUMERIC) \
|
134
|
|
- s_name = val->v.longVal; \
|
135
|
|
- else if (val->valType == OPARG_TYPE_STRING) \
|
136
|
|
- s_name = atoi(val->v.strVal); \
|
137
|
|
-- }
|
138
|
|
-+ }}
|
139
|
|
-
|
140
|
|
--#define READ_RAW_PRIO_TOS(name, s_name) \
|
141
|
|
-+#define READ_RAW_PRIO_TOS(name, s_name) { \
|
142
|
|
- val = optionGetValue(pov, name); \
|
143
|
|
- if (val != NULL) { \
|
144
|
|
- if (val->valType == OPARG_TYPE_STRING) { \
|
145
|
|
-@@ -108,9 +108,9 @@ static struct cfg_options available_options[] = {
|
146
|
|
- s_name++; \
|
147
|
|
- } \
|
148
|
|
- } \
|
149
|
|
-- }
|
150
|
|
-+ }}
|
151
|
|
-
|
152
|
|
--#define READ_TF(name, s_name, def) \
|
153
|
|
-+#define READ_TF(name, s_name, def) { \
|
154
|
|
- { char* tmp_tf = NULL; \
|
155
|
|
- READ_RAW_STRING(name, tmp_tf); \
|
156
|
|
- if (tmp_tf == NULL) s_name = def; \
|
157
|
|
-@@ -121,7 +121,7 @@ static struct cfg_options available_options[] = {
|
158
|
|
- s_name = 0; \
|
159
|
|
- } \
|
160
|
|
- talloc_free(tmp_tf); \
|
161
|
|
-- }
|
162
|
|
-+ }}
|
163
|
|
-
|
164
|
|
- static int handle_option(const tOptionValue* val)
|
165
|
|
- {
|
166
|
|
-2.0.0
|
167
|
|
-
|